Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce macro usage #609

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Reduce macro usage #609

merged 9 commits into from
Dec 13, 2024

Conversation

wheeheee
Copy link
Member

@wheeheee wheeheee commented Dec 12, 2024

also use more tanpi

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.94%. Comparing base (8607be8) to head (3197b98).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Filters/filt_order.jl 92.45% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   97.96%   97.94%   -0.03%     
==========================================
  Files          19       19              
  Lines        3248     3255       +7     
==========================================
+ Hits         3182     3188       +6     
- Misses         66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Filters/filt_order.jl Outdated Show resolved Hide resolved
src/Filters/filt_order.jl Outdated Show resolved Hide resolved
src/Filters/filt_order.jl Outdated Show resolved Hide resolved
src/windows.jl Outdated Show resolved Hide resolved
src/windows.jl Outdated Show resolved Hide resolved
src/Filters/filt_order.jl Outdated Show resolved Hide resolved
@martinholters
Copy link
Member

Any special reason those @inlines?

@wheeheee
Copy link
Member Author

They're only called by those few functions, and they are specialized on the estimation functions too, so might as well avoid one function call.

@martinholters
Copy link
Member

Ah, yes, makes sense.

@wheeheee wheeheee merged commit d8d423d into JuliaDSP:master Dec 13, 2024
8 of 10 checks passed
@wheeheee wheeheee deleted the hofs branch December 13, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants