Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add Small Note about Method Validations #561

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

TheCedarPrince
Copy link
Contributor

Hey there!

After a discussion with @ericphanson , I learned that DSP.jl is actually validated against MATLAB and MNE-Python! In my eyes, that made using DSP.jl much more salient to me in knowing that, although its methods are made in Julia from scratch, they are compared with suites that are considered state of the art in many domains. I know it is a small edit, but I thought it was worthwhile enough to update the docs here because if I think that way, it may appeal to other folks thinking similarly.

@martinholters
Copy link
Member

DSP.jl is actually validated against MATLAB and MNE-Python

I think that is only true for part of DSP.jl.

@ericphanson
Copy link
Contributor

@TheCedarPrince
Copy link
Contributor Author

That's very reasonable @martinholters -- I updated my PR to reflect that point.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (76001f4) to head (07afedc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #561   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files          18       18           
  Lines        3199     3199           
=======================================
  Hits         3127     3127           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Contributor

I'm merging for now, but it can easily be fine tuned later.

@ViralBShah ViralBShah merged commit 275cd2e into JuliaDSP:master Aug 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants