Fix bounds errors when resampling with some arbitrary ratios #539
Conversation
anowacki
force-pushed
the
an/fix-resample-bounds-error
branch
from
7f85d33 to
268f3be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #539 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 18 18
Lines 3125 3127 +2
=======================================
+ Hits 3049 3051 +2
Misses 76 76 ☔ View full report in Codecov by Sentry. |
In some cases when `filt(::FIRFilter{FIRArbitrary}, x)` is called
with certain values of `x`, `filt!(buffer, ::FIRFilter{FIRArbitrary}, x)`
tries to write one sample too many to the buffer and a `BoundsError`
is thrown. Add one extra sample to the buffer to catch these
exceptional cases.
(This code is really a hack and simply works around the deeper problem
of calculating the correct output buffer length; this should instead be
addressed properly in a future change.)
Closes JuliaDSP#317.
anowacki
force-pushed
the
an/fix-resample-bounds-error
branch
from
268f3be to
b790b4e
Compare
|
The following isn't quite correct:
The output buffer is the correct length; it is the writing to the buffer in the |
|
@anowacki Would it be helpful for you to have commit access with the repo to help with maintenance? Not a whole lot changes workflow wise (PRs, reviews, etc), but we have more hands to keep things going and to improve the package. |
|
@ViralBShah I'm not averse to the idea, but I'm really only making PRs for things that I have already sorted out locally to get work done. I would also not consider myself as much of an expert on signal processing as I would like to be to help maintain the repo. |
|
Thanks. Happy to add you later if it makes sense. Just let me know. |
|
Merge? |
|
I ran into this issue and found that it is fixed on the main branch. @martinholters would it be possible to trigger a release including this fix? |
In some cases when `filt(::FIRFilter{FIRArbitrary}, x)` is called
with certain values of `x`, `filt!(buffer, ::FIRFilter{FIRArbitrary}, x)`
tries to write one sample too many to the buffer and a `BoundsError`
is thrown. Add one extra sample to the buffer to catch these
exceptional cases.
(This code is really a hack and simply works around the deeper problem
of calculating the correct output buffer length; this should instead be
addressed properly in a future change.)
Closes #317.
(cherry picked from commit 73d3214)
In some cases when `filt(::FIRFilter{FIRArbitrary}, x)` is called
with certain values of `x`, `filt!(buffer, ::FIRFilter{FIRArbitrary}, x)`
tries to write one sample too many to the buffer and a `BoundsError`
is thrown. Add one extra sample to the buffer to catch these
exceptional cases.
(This code is really a hack and simply works around the deeper problem
of calculating the correct output buffer length; this should instead be
addressed properly in a future change.)
Closes #317.
(cherry picked from commit 73d3214)
In some cases when
filt(::FIRFilter{FIRArbitrary}, x)is calledwith certain values of
x, the buffer is actually one sample tooshort and a
BoundsErroris thrown infilt!(buffer, ::FIRFilter{FIRArbitrary}, x). Add one extra sampleto the calculated buffer length to catch these exceptional cases, which
mostly arise when resampling with particular resampling ratios.
(This code is really a hack and simply works around the deeper problem
of
calculating the correct output buffer lengthwriting the correct number of points infilt!; this should instead beaddressed properly in a future change.)
Closes #317.