Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix @printfifinteractive in test #515

Merged
merged 4 commits into from
Feb 5, 2024
Merged

fix @printfifinteractive in test #515

merged 4 commits into from
Feb 5, 2024

Conversation

wheeheee
Copy link
Member

  • test filt_stream.jl now successfully prints when run interactively
  • rectified some typos
  • remove Base. and DSP. prefix from filt, since Base doesn't have filt anymore

@wheeheee
fix @prinfifinteractive
3186ac5 
used to error if `isinteractive() == true`
@wheeheee
fix typos
ee1810e 
- no Base.filt now, changed DSP.filt to filt
- under test_decimation, fixed repeated typeof(h) to typeof(x)
- minor typos
@wheeheee
avoid minimum(f, x) for 1.0
45a534f
@wheeheee
add \ns
8c46223
@ViralBShah ViralBShah closed this Jan 20, 2024
@ViralBShah ViralBShah reopened this Jan 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e3524f) 97.29% compared to head (8c46223) 97.29%.
Report is 7 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #515   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          18       18           
  Lines        3105     3105           
=======================================
  Hits         3021     3021           
  Misses         84       84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wheeheee
Copy link
Member Author

wheeheee commented Feb 5, 2024

I think this PR is quite safe, so if no one has any objections, will merge in a week?

@ViralBShah
Copy link
Contributor

This seems ok to go ahead and merge.

@ViralBShah ViralBShah merged commit 54f13b6 into JuliaDSP:master Feb 5, 2024
9 checks passed
@wheeheee wheeheee added the no changelog Prevent TagBot from inclusion in release notes label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViralBShah ViralBShah ViralBShah approved these changes

Assignees
No one assigned
Labels
no changelog Prevent TagBot from inclusion in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wheeheee @codecov-commenter @ViralBShah