Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use length of arrays directly in conv #494

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Dec 16, 2022

This may save an unnecessary call to prod

This may save an unnecessary call to `prod`
@codecov-commenter
Copy link

Codecov Report

Base: 96.83% // Head: 93.25% // Decreases project coverage by -3.58% ⚠️

Coverage data is based on head (ba0586f) compared to base (e449411).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
- Coverage   96.83%   93.25%   -3.59%     
==========================================
  Files          16       16              
  Lines        3095     1867    -1228     
==========================================
- Hits         2997     1741    -1256     
- Misses         98      126      +28     
Impacted Files Coverage Δ
src/dspbase.jl 86.87% <100.00%> (-10.78%) ⬇️
src/diric.jl 81.25% <0.00%> (-18.75%) ⬇️
src/util.jl 85.71% <0.00%> (-8.66%) ⬇️
src/periodograms.jl 89.92% <0.00%> (-8.11%) ⬇️
src/Filters/coefficients.jl 93.22% <0.00%> (-6.78%) ⬇️
src/unwrap.jl 90.44% <0.00%> (-5.11%) ⬇️
src/windows.jl 83.15% <0.00%> (-4.75%) ⬇️
src/Filters/stream_filt.jl 92.97% <0.00%> (-4.15%) ⬇️
src/Filters/filt.jl 96.80% <0.00%> (-2.80%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ViralBShah ViralBShah merged commit bf938fb into JuliaDSP:master Feb 5, 2024
@jishnub jishnub deleted the patch-2 branch February 5, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants