Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate nonscalar nextfastfft methods? #291

Open
ssfrr opened this issue Apr 26, 2019 · 0 comments
Open

Deprecate nonscalar nextfastfft methods? #291

ssfrr opened this issue Apr 26, 2019 · 0 comments
Labels

Comments

@ssfrr
Copy link
Contributor

ssfrr commented Apr 26, 2019

If a user has a dims tuple we currently have 3 different ways to call nextfastfft defined here:

  • nextfastfft(dims)
  • nextfastfft(dims...)
  • nextfastfft.(dims)

In general this sort of automatic collection handling has been getting deprecated in favor of having the caller use broadcasting (option 3 above). I propose we deprecate the first 2.

It's possible that the multi-arg version (nextfastfft(x, y)) is useful, but I don't think that we as a general policy expand other single-arg functions in this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants