Skip to content

Commit

Permalink
Rework offset-axes check in three-arg conv
Browse files Browse the repository at this point in the history
  • Loading branch information
martinholters committed Nov 11, 2024
1 parent 249155f commit bf14a3c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/dspbase.jl
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,9 @@ Uses 2-D FFT algorithm.
"""
function conv(u::AbstractVector{T}, v::Transpose{T,<:AbstractVector}, A::AbstractMatrix{T}) where T
# Arbitrary indexing offsets not implemented
@assert !Base.has_offset_axes(u, v, A)
if any(conv_with_offset, (axes(u)..., axes(v)..., axes(A)...))
throw(ArgumentError("offset axes not supported"))

Check warning on line 796 in src/dspbase.jl

View check run for this annotation

Codecov / codecov/patch

src/dspbase.jl#L796

Added line #L796 was not covered by tests
end
m = length(u)+size(A,1)-1
n = length(v)+size(A,2)-1
B = zeros(T, m, n)
Expand Down

0 comments on commit bf14a3c

Please sign in to comment.