Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle breaking change in Polynomials #829

Merged
merged 1 commit into from
Apr 19, 2023
Merged

handle breaking change in Polynomials #829

merged 1 commit into from
Apr 19, 2023

Conversation

baggepinnen
Copy link
Member

closes #828

the breaking change was introduced by

more specifically,

Uses T[] for the coefficients of a 0 polynomial, not T[0], which requires zero(T). This led to some fixes on evaluation and changed some tests

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #829 (74740e8) into master (3a4d05e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files           4        4           
  Lines         315      315           
=======================================
  Hits          306      306           
  Misses          9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@baggepinnen baggepinnen merged commit 79672c4 into master Apr 19, 2023
@baggepinnen baggepinnen deleted the polyfix branch April 19, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting "identity" transfert function with ss results in BoundsError
2 participants