Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect freqresp against loading GenericLinearAlgebra #637

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

baggepinnen
Copy link
Member

GLA returns it's own Hessenberg struct that does not have Q, so loading GLA might break freqresp due to GLA doing type piracy :/

GLA returns it's own Hessenberg struct that does not have Q, so loading GLA might break freqresp due to GLA doing type piracy :/
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 9/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.003 Reference New
✔️ 0.003 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
❌ 0.042 Reference New
✔️ 0.006 Reference New
✔️ 0.011 Reference New

@baggepinnen baggepinnen changed the title generprotect freqresp against loading GenericLinearAlgebra protect freqresp against loading GenericLinearAlgebra Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #637 (f5ecd73) into master (1d81af0) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #637   +/-   ##
=======================================
  Coverage   86.73%   86.73%           
=======================================
  Files          31       31           
  Lines        3248     3248           
=======================================
  Hits         2817     2817           
  Misses        431      431           
Impacted Files Coverage Δ
src/freqresp.jl 96.24% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d81af0...f5ecd73. Read the comment docs.

@baggepinnen baggepinnen merged commit 5abb72f into master Feb 17, 2022
@baggepinnen baggepinnen deleted the safefreqresp branch February 17, 2022 07:33
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 9/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.003 Reference New
✔️ 0.003 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
❌ 0.042 Reference New
✔️ 0.006 Reference New
✔️ 0.011 Reference New

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants