Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chunked response interruption handling #46

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

tanmaykm
Copy link
Member

When the caller closes the response stream in order to interrupt the streaming chunked request, Swagger task may get partial data. It should not throw an error in that case.

When the caller closes the response stream in order to interrupt the streaming chunked request, Swagger task may get partial data. It should not throw an error in that case.
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #46 (579f365) into master (ad33535) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   68.27%   68.62%   +0.35%     
==========================================
  Files           4        4              
  Lines         290      306      +16     
==========================================
+ Hits          198      210      +12     
- Misses         92       96       +4     
Impacted Files Coverage Δ
src/client.jl 70.16% <100.00%> (+0.83%) ⬆️
src/val.jl 37.93% <0.00%> (-2.81%) ⬇️
src/json.jl 81.57% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad33535...579f365. Read the comment docs.

@tanmaykm tanmaykm merged commit c5dc1a3 into master Oct 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the tan/chunkedresp branch October 29, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants