allow long polling request to be interrupted #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmaykm
force-pushed
the
tan/interrupt
branch
from
f318005 to
2139434
Compare
Allow long polling request to be interrupted by closing the output channel. There is no ready API/mechanism in Downloads.jl to interrupt a request. Here we just throw an InterruptedException to the task that invoked Downloads.request. Note: A better mechanism may be to invoke `remove_handle(multi::Multi, easy::Easy)`, but that should probably be through an interruption mechanism provided by Downloads.jl?
tanmaykm
force-pushed
the
tan/interrupt
branch
from
2139434 to
04a9a32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow long polling request to be interrupted by closing the output channel.
There is no ready API/mechanism in Downloads.jl to interrupt a request.
Here we just throw an InterruptedException to the task that invoked Downloads.request.
Note: A better mechanism may be to invoke
remove_handle(multi::Multi, easy::Easy), but that should probably be through an interruption mechanism provided by Downloads.jl?