Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: work around missing method error in JET #75

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mortenpi
Copy link
Member

With probably 1.11, we started getting a

JET: JET-test failed at /home/runner/.julia/packages/JET/zHVn3/src/JET.jl:107[8](https://github.com/JuliaComputing/JuliaHub.jl/actions/runs/11589518895/job/32265190402?pr=74#step:6:9)
  Expression: (JET.report_package)("JuliaHub"; toplevel_logger = nothing, report_config = JuliaHubReportFilter())
  ═════ 1 possible error found ═════
  ┌ submit_job(app::JuliaHub.AbstractJobConfig; ncpu::Integer, ngpu::Integer, memory::Integer, nnodes::Union{…}, elastic::Bool, process_per_node::Bool, auth::JuliaHub.Authentication, kwargs...) @ JuliaHub /home/runner/work/JuliaHub.jl/JuliaHub.jl/src/jobsubmission.jl:1186
  │┌  @ JuliaHub /home/runner/work/JuliaHub.jl/JuliaHub.jl/src/jobsubmission.jl:118[9](https://github.com/JuliaComputing/JuliaHub.jl/actions/runs/11589518895/job/32265190402?pr=74#step:6:10)
  ││┌ submit_job(app::JuliaHub.AbstractJobConfig, compute::JuliaHub.ComputeConfig; name::Union{…}, alias::Union{…}, env::Any, project::Union{…}, timelimit::Union{…}, expose::Union{…}, _image_sha256::Union{…}, kwargs...) @ JuliaHub /home/runner/work/JuliaHub.jl/JuliaHub.jl/src/jobsubmission.jl:1216
  │││┌ submit_job(c::JuliaHub.WorkloadConfig) @ JuliaHub /home/runner/work/JuliaHub.jl/JuliaHub.jl/src/jobsubmission.jl:[12](https://github.com/JuliaComputing/JuliaHub.jl/actions/runs/11589518895/job/32265190402?pr=74#step:6:13)22
  ││││┌  @ JuliaHub /home/runner/work/JuliaHub.jl/JuliaHub.jl/src/jobsubmission.jl:1249
  │││││ no matching method found `convert(::Type{Dict}, ::NamedTuple)`: convert(JuliaHub.Dict, _26::NamedTuple)
  ││││└────────────────────

from JET. Unsure exactly why, but in this case, the type assertion also sort of functions as documentation -- the .args field from the app name tuple should always be a Dict. So it seems file to work around the issue like this.

@mortenpi mortenpi requested a review from a team October 31, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant