Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape unused DateFormat characters #236

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

omus
Copy link
Member

@omus omus commented Feb 7, 2022

Required to fix errors when running test suite with #231:

  Got exception outside of a @test
  type DateTime has no field zone
  Stacktrace:
    [1] getproperty
      @ ./Base.jl:42 [inlined]
    [2] format(io::IOBuffer, d::Dates.DatePart{'Z'}, zdt::DateTime, locale::Dates.DateLocale)
      @ TimeZones ~/.julia/packages/TimeZones/1ALMR/src/parse.jl:81
    [3] macro expansion
      @ /opt/hostedtoolcache/julia/1.7.1/x64/share/julia/stdlib/v1.7/Dates/src/io.jl:634 [inlined]
    [4] format(io::IOBuffer, dt::DateTime, fmt::DateFormat{:yyyymmddTHHMMSSZ, Tuple{Dates.DatePart{'y'}, Dates.DatePart{'m'}, Dates.DatePart{'d'}, Dates.Delim{Char, 1}, Dates.DatePart{'H'}, Dates.DatePart{'M'}, Dates.DatePart{'S'}, Dates.DatePart{'Z'}}})
      @ Dates /opt/hostedtoolcache/julia/1.7.1/x64/share/julia/stdlib/v1.7/Dates/src/io.jl:629
    [5] format(dt::DateTime, fmt::DateFormat{:yyyymmddTHHMMSSZ, Tuple{Dates.DatePart{'y'}, Dates.DatePart{'m'}, Dates.DatePart{'d'}, Dates.Delim{Char, 1}, Dates.DatePart{'H'}, Dates.DatePart{'M'}, Dates.DatePart{'S'}, Dates.DatePart{'Z'}}}, bufsize::Int64)
      @ Dates /opt/hostedtoolcache/julia/1.7.1/x64/share/julia/stdlib/v1.7/Dates/src/io.jl:641
    [6] format(dt::DateTime, fmt::DateFormat{:yyyymmddTHHMMSSZ, Tuple{Dates.DatePart{'y'}, Dates.DatePart{'m'}, Dates.DatePart{'d'}, Dates.Delim{Char, 1}, Dates.DatePart{'H'}, Dates.DatePart{'M'}, Dates.DatePart{'S'}, Dates.DatePart{'Z'}}})
      @ Dates /opt/hostedtoolcache/julia/1.7.1/x64/share/julia/stdlib/v1.7/Dates/src/io.jl:640
    [7] format(dt::DateTime, f::String; locale::Dates.DateLocale)
      @ Dates /opt/hostedtoolcache/julia/1.7.1/x64/share/julia/stdlib/v1.7/Dates/src/io.jl:680
    [8] format
      @ /opt/hostedtoolcache/julia/1.7.1/x64/share/julia/stdlib/v1.7/Dates/src/io.jl:680 [inlined]
    [9] awss3_tests(config::MinioConfig)
      @ Main ~/work/AWSS3.jl/AWSS3.jl/test/awss3.jl:2
   [10] macro expansion
      @ ~/work/AWSS3.jl/AWSS3.jl/test/runtests.jl:43 [inlined]
   [11] macro expansion
      @ /opt/hostedtoolcache/julia/1.7.1/x64/share/julia/stdlib/v1.7/Test/src/Test.jl:1283 [inlined]
   [12] macro expansion
      @ ~/work/AWSS3.jl/AWSS3.jl/test/runtests.jl:43 [inlined]
   [13] macro expansion
      @ /opt/hostedtoolcache/julia/1.7.1/x64/share/julia/stdlib/v1.7/Test/src/Test.jl:1283 [inlined]
   [14] top-level scope
      @ ~/work/AWSS3.jl/AWSS3.jl/test/runtests.jl:23
   [15] include(fname::String)
      @ Base.MainInclude ./client.jl:451
   [16] top-level scope
      @ none:6
   [17] eval
      @ ./boot.jl:373 [inlined]
   [18] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:268
   [19] _start()
      @ Base ./client.jl:495

@omus omus self-assigned this Feb 7, 2022
@omus
Copy link
Member Author

omus commented Feb 7, 2022

Proceeding with merging right away as this change is very straight forward

@omus
Copy link
Member Author

omus commented Feb 7, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 7, 2022

@bors bors bot merged commit fc96007 into master Feb 7, 2022
@bors bors bot deleted the cv/escape-dateformat-chars branch February 7, 2022 15:25
bors bot added a commit that referenced this pull request Feb 7, 2022
237: Escape unused DateFormat characters (again) r=omus a=omus

Follow up to #236. I missed this use of `Dates.format`.

Co-authored-by: Curtis Vogt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant