bump mbed_tls version to 0.7 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
bors bot
added a commit
that referenced
this pull request
Nov 6, 2019
97: bump mbed_tls version to 0.7 r=mattBrzezinski a=SebRollen Hi, The discussion in a recent discourse thread (and [this post](https://discourse.julialang.org/t/please-be-mindful-of-version-bounds-and-semantic-versioning-when-tagging-your-packages/30708/95) in particular) prompted me to try to track down some packages that led to downgrades in other packages when I run `]up`. Based on [this list](https://gist.github.com/KristofferC/7c8048e2ee9aaa465966caeb98c1446a), it looks like `AWSCore` is restricting `MbedTLS.jl` to a lower version than the latest, so this pr just bumps the allowed range to include [0.7, 0.8). I ran the test-suite locally and everything seemed to work fine, but also understand that there may be a lot more nuances to the upgrade than just the test-suite Co-authored-by: Sebastian Rollen <[email protected]>
|
Once this is in, we can bump the version in: It should be noted that originally I did not include And issue for this can be found here. |
tryBuild succeeded |
|
@SebRollen can you also bump the version so we can take and make a release when this is merged in? |
|
@mattBrzezinski, done. Tried to look for a |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 6, 2019
97: bump mbed_tls version to 0.7 r=mattBrzezinski a=SebRollen Hi, The discussion in a recent discourse thread (and [this post](https://discourse.julialang.org/t/please-be-mindful-of-version-bounds-and-semantic-versioning-when-tagging-your-packages/30708/95) in particular) prompted me to try to track down some packages that led to downgrades in other packages when I run `]up`. Based on [this list](https://gist.github.com/KristofferC/7c8048e2ee9aaa465966caeb98c1446a), it looks like `AWSCore` is restricting `MbedTLS.jl` to a lower version than the latest, so this pr just bumps the allowed range to include [0.7, 0.8). I ran the test-suite locally and everything seemed to work fine, but also understand that there may be a lot more nuances to the upgrade than just the test-suite Co-authored-by: Sebastian Rollen <[email protected]>
Build succeeded |
bors bot
added a commit
to JuliaCloud/AWSS3.jl
that referenced
this pull request
Nov 6, 2019
59: Project.toml include [email protected] r=mattBrzezinski a=mattBrzezinski When `[AWSCore #97](JuliaCloud/AWSCore.jl#97) goes in we can include `[email protected]` in this package. **Note**: Using `[email protected]` will not work w/ Julia `<v1.2` Co-authored-by: Matt Brzezinski <[email protected]>
bors bot
added a commit
to JuliaCloud/AWSS3.jl
that referenced
this pull request
Nov 6, 2019
59: Project.toml include [email protected] r=mattBrzezinski a=mattBrzezinski When `[AWSCore #97](JuliaCloud/AWSCore.jl#97) goes in we can include `[email protected]` in this package. **Note**: Using `[email protected]` will not work w/ Julia `<v1.2` Co-authored-by: Matt Brzezinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The discussion in a recent discourse thread (and this post in particular) prompted me to try to track down some packages that led to downgrades in other packages when I run
]up.Based on this list, it looks like
AWSCoreis restrictingMbedTLS.jlto a lower version than the latest, so this pr just bumps the allowed range to include [0.7, 0.8). I ran the test-suite locally and everything seemed to work fine, but also understand that there may be a lot more nuances to the upgrade than just the test-suite