CPU_CORES has been renamed to CPU_THREADS

[ararslan]

Ref JuliaLang/julia#28091. We'll just need to be careful for any hypothetical future 0.6 releases to specify JULIA_CPU_CORES just as we do with JULIA_CPU_TARGET.

[staticfloat]

How's about for the make flags we set both for now, and then we don't have to worry about it. We can put in a comment saying to remove this once 0.6 building is no longer a possibility.

[ararslan]

I think the probability of a 0.6 release is vanishingly small at this point, and I'm not sure what happens when you supply both environment variables. (I assume it uses the right one but I'm not sure whether it still issues a deprecation warning when it sees the old one. EDIT: It does not, we're good.) I can add back the old too though.

[staticfloat]

If it’s vanishingly small, then feel free to merge as-is. You’re most likely the one to know after all. ;)

On Wed, Aug 1, 2018 at 18:09 Alex Arslan ***@***.***> wrote: I think the probability of a 0.6 release is vanishingly small at this point, and I'm not sure what happens when you supply both environment variables. (I assume it uses the right one but I'm not sure whether it still issues a deprecation warning when it sees the old one.) I can add back the old too though. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#85 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAH_aMozyhXdgIzbxle_pR2dzxgAg-K_ks5uMlFmgaJpZM4VPo-7> .

--

…

-E