Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip and cancel intermediate builds #325

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

devmotion
Copy link
Contributor

This PR changes the Github CI template such that intermediate builds are always skipped and cancelled in PRs.

I was not sure if you would like this to be an opt-in or opt-out feature. I guess opt-out would be most useful if you would like to add a configuration option.

Fixes #323.

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #325 (e895da0) into master (336ac2f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          20       20           
  Lines         614      614           
=======================================
  Hits          582      582           
  Misses         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336ac2f...e895da0. Read the comment docs.

Copy link
Collaborator

@nickrobinson251 nickrobinson251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

an opt-in or opt-out feature. I guess opt-out would be most useful if you would like to add a configuration option.

is there a reason to even add it is an option? if there is, then i agree that opt-out sounds best. But i'd be inclined to just merge as-is. We can always add a config option at a later date if it's requested

@devmotion
Copy link
Contributor Author

I don't think an option is needed, I was just not sure what you would prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to cancel CI of intermediate commits in PRs?
2 participants