-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the value that will be used if not customized #177
Conversation
I think I like this idea, because seeing the default value definitely gives a nice hint as to what the option actually does before you commit to customizing it. I wonder if with this change we could change the input parsing to turn empty strings into Could you also make the same change in |
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 89.54% 89.58% +0.04%
==========================================
Files 18 18
Lines 507 509 +2
==========================================
+ Hits 454 456 +2
Misses 53 53
Continue to review full report at Codecov.
|
I extended this PR a bit and came up with this: julia> Template(; interactive=true)
Template keywords to customize:
[press: d=done, a=all, n=none]
[ ] user ("christopher-dG")
[ ] authors ("Chris de Graaf <[email protected]> and contributors")
[X] dir ("~/.local/share/julia/dev")
[ ] host ("github.com")
[ ] julia (v"1.0.0")
> [X] plugins (PkgTemplates.Plugin[])
Enter value for 'dir' (String): ~/code
Select plugins:
[press: d=done, a=all, n=none]
[ ] CompatHelper
[ ] ProjectFile
[ ] SrcDir
[ ] Git
[ ] License
[ ] Readme
[ ] Tests
[X] TagBot
[ ] AppVeyor
[ ] CirrusCI
[ ] Citation
> [X] Codecov
[ ] Coveralls
[ ] Develop
[ ] Documenter
[ ] DroneCI
[ ] GitHubActions
[ ] GitLabCI
[X] TravisCI
TagBot keywords to customize:
[press: d=done, a=all, n=none]
> [ ] branches (nothing)
[ ] changelog (nothing)
[ ] changelog_ignore (nothing)
[ ] cron ("0 0 * * *")
[ ] destination ("TagBot.yml")
[ ] dispatch (nothing)
[ ] dispatch_delay (nothing)
[ ] file ("~/code/PkgTemplates/templates/github/workflows/TagBot.yml")
[ ] gpg (nothing)
[ ] gpg_password (nothing)
[ ] registry (nothing)
[ ] ssh (nothing)
[ ] ssh_password (nothing)
[ ] token (Secret("GITHUB_TOKEN"))
Codecov keywords to customize:
[press: d=done, a=all, n=none]
> [ ] file (nothing)
[ ] None (No customization)
TravisCI keywords to customize:
[press: d=done, a=all, n=none]
> [ ] arm64 (false)
[ ] coverage (true)
[ ] extra_versions (["1.0", "1.4", "nightly"])
[ ] file ("~/code/PkgTemplates/templates/travis.yml")
[ ] linux (true)
[ ] osx (true)
[ ] windows (true)
[ ] x64 (true)
[ ] x86 (false) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 92.95% 93.80% +0.84%
==========================================
Files 24 24
Lines 738 742 +4
==========================================
+ Hits 686 696 +10
+ Misses 52 46 -6 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Chris de Graaf <[email protected]>
@oxinabox asking for a review because this might seem slightly overwhelming for beginning users (it adds a lot of info to the interactive menus), but at the same time I think the addition is welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a net improvement
No description provided.