Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coveralls submission, and re-enable Coveralls submission from CI #315

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Fix Coveralls submission, and re-enable Coveralls submission from CI #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Coverage"
uuid = "a2441757-f6aa-5fb2-8edb-039e3f45d037"
authors = ["Iain Dunning <[email protected]>", "contributors"]
version = "1.2.0"
version = "1.2.1"

[deps]
CoverageTools = "c36e975a-824b-4404-a568-ef97ca766997"
Expand Down
2 changes: 1 addition & 1 deletion etc/travis-coverage.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Coverage
cov_res = process_folder()
Codecov.submit(cov_res)
haskey(ENV, "COVERALLS_URL") && Coveralls.submit(cov_res)
Coveralls.submit(cov_res)
4 changes: 2 additions & 2 deletions src/coveralls.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ module Coveralls
function to_json(fc::FileCoverage)
name = Sys.iswindows() ? replace(fc.filename, '\\' => '/') : fc.filename
return Dict("name" => name,
"source_digest" => digest(MD_MD5, fc.source, "secret"),
"source_digest" => bytes2hex(digest(MD_MD5, fc.source, "secret")),
"coverage" => fc.coverage)
end

Expand Down Expand Up @@ -102,7 +102,7 @@ module Coveralls
event_path = open(JSON.Parser.parse, ENV["GITHUB_EVENT_PATH"])
github_pr_info = get(event_path, "pull_request", Dict())
github_pr = get(github_pr_info, "number", "")
isempty(github_pr) || (data["service_pull_request"] = github_pr)
isempty(github_pr) || (data["service_pull_request"] = strip(string(github_pr)))
else
data["git"] = parse_git_info(git_info)
end
Expand Down