Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Coveralls submission from CI #310

Closed
wants to merge 3 commits into from
Closed

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented May 10, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #310 (30621f2) into master (e0655f8) will increase coverage by 0.51%.
The diff coverage is n/a.

❗ Current head 30621f2 differs from pull request most recent head 8f2817d. Consider uploading reports for the commit 8f2817d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   90.25%   90.76%   +0.51%     
==========================================
  Files           2        2              
  Lines         195      195              
==========================================
+ Hits          176      177       +1     
+ Misses         19       18       -1     
Impacted Files Coverage Δ
src/coveralls.jl 94.17% <0.00%> (-1.95%) ⬇️
src/codecovio.jl 86.95% <0.00%> (+3.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0655f8...8f2817d. Read the comment docs.

@DilumAluthge DilumAluthge reopened this Jun 8, 2021
@DilumAluthge
Copy link
Member

@vtjnash Any idea why this is failing?

@vtjnash
Copy link
Member Author

vtjnash commented Jun 9, 2021

Probably a coveralls bug. Perhaps if we use the new API, it will bypass their bug (#304), otherwise we may need to message them for a fix

@vtjnash
Copy link
Member Author

vtjnash commented Jun 9, 2021

Oh, perhaps it is one of these issues: lemurheavy/coveralls-public#1527

@vtjnash vtjnash closed this Jun 9, 2021
@vtjnash vtjnash deleted the jn/coveralls-ci branch June 9, 2021 04:21
@DilumAluthge DilumAluthge restored the jn/coveralls-ci branch June 9, 2021 04:26
@DilumAluthge DilumAluthge deleted the jn/coveralls-ci branch June 9, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants