InferenceBenchmarks: allow benchmark against Compiler as the stdlib
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is especially useful for optimizing the compiler’s implementation while using Revise in a local environment.
Keno
reviewed
Nov 14, 2024
| @@ -18,7 +18,15 @@ module InferenceBenchmarks | |||
| # managed by the runtime system: this allows us to profile Julia-level inference reliably | |||
| # without being influenced by previous trials or some native execution | |||
|
|
|||
| @static if VERSION ≥ v"1.12.0-DEV.1581" | |||
| if Base.REFLECTION_COMPILER[] === nothing | |||
There was a problem hiding this comment.
I'm a little concerned about this one. This is a runtime variable, but used in a compile-time context. It probably works fine for now, but we may want to do something like eval things on the fly when requested.
There was a problem hiding this comment.
An eval-based implementation seems more correct. We need to be cautious about whether it affects benchmarks though. Currently the benchmark modules in BaseBenchmarks.jl are not precompiled, and since these benchmarks are essentially runtime-only, this approach should be fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially useful for optimizing the compiler’s implementation while using Revise in a local environment.