Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve a couple benchmark implementations #283

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

improve a couple benchmark implementations #283

wants to merge 3 commits into from

Commits on Apr 14, 2021

  1. convert BinaryTree to slightly more canonical Julia form 

    With no node mutation, it is unclear why this is mutable (which costs
some extra loads), though the recursion forces this to the heap
regardless. But singleton struct Empty needs to be non-mutable now for
correctness
    @vtjnash
    vtjnash committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    dd25659 View commit details
    Browse the repository at this point in the history

  2. use appropriate optimizations in regex_dna 

    The multi-replace method is being added in JuliaLang/julia#40484
    @vtjnash
    vtjnash committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    94dba74 View commit details
    Browse the repository at this point in the history

  3. improve quality of perf_parse_json implementation 

    Allocating strings with json character-by-character with ""+c+c+… is bad
style, and this was not handling \u correctly either. We could make
strcat a separate micro-benchmark, but it is not a particularly
interesting test case currently.
    @vtjnash
    vtjnash committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    9dee1b2 View commit details
    Browse the repository at this point in the history