remove angstrom #14
Comments
|
Yes, that's a good idea. Would you mind opening a pull request yourself? 🙂 |
|
Sure! |
xzackli
added a commit
to xzackli/UnitfulAstro.jl
that referenced
this issue
Dec 7, 2019
xzackli
added a commit
to xzackli/UnitfulAstro.jl
that referenced
this issue
Dec 7, 2019
giordano
added a commit
that referenced
this issue
Jan 3, 2020
* removed every mention of angstrom as it is now redundant, fixes issue #14 * reverted changes to NEWS.md and tests, bumped compat version of Unitful to 0.18.0 * fixed test by including base Unitful * Unitful angstrom is implemented as a rational number type multiplied by the nanometer, so we should write tests with the rational number type * promotion to Float64 in angstrom test * Use uppor bounds in compat section * Use isapprox for angstrom test * Restore other test Co-authored-by: Mosè Giordano <[email protected]>
|
Tag a new release with registrator? |
|
Done, thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to PainterQubits/Unitful.jl#271 there is now a duplication in Unitful and UnitfulAstro for
Angstrom. Since nobody will be using UnitfulAstro alone, just remove all references to it in this package?(Thanks for the great package!)
The text was updated successfully, but these errors were encountered: