Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide constructors from generators #792

Merged
merged 11 commits into from
May 23, 2020
Merged

Provide constructors from generators #792

merged 11 commits into from
May 23, 2020

Conversation

eschnett
Copy link
Contributor

Closes #791.

tkf
tkf reviewed May 19, 2020
View reviewed changes
src/SArray.jl Outdated Show resolved Hide resolved
tkf
tkf reviewed May 19, 2020
View reviewed changes
src/SArray.jl Outdated Show resolved Hide resolved
tkf
tkf reviewed May 19, 2020
View reviewed changes
src/SArray.jl Outdated Show resolved Hide resolved
tkf
tkf reviewed May 19, 2020
View reviewed changes
src/SMatrix.jl Outdated Show resolved Hide resolved
@eschnett
Implement sacollect. Add error messages.
c01fb96 
This also much simplifies the code.
tkf
tkf reviewed May 19, 2020
View reviewed changes
src/SArray.jl Show resolved Hide resolved
src/SArray.jl Outdated Show resolved Hide resolved
src/SArray.jl Outdated Show resolved Hide resolved
@eschnett
Copy link
Contributor Author

I see that you are testing with Julia 1.0, ..., 1.3. I'm currently seeing test failures with Julia 1.1. Do you still want to support Julia 1.1? It's not officially supported any more. If you do, I'll install Julia 1.1 to debug.

I also see that you are not testing with Julia 1.4, the currently recommended version. I would add it.

@andyferris
Copy link
Member

I see that you are testing with Julia 1.0, ..., 1.3. I'm currently seeing test failures with Julia 1.1. Do you still want to support Julia 1.1?

I don't have strong opinions but we've generally tried to be "quite" compabilble in the past. We should definitely at least start testing 1.4!

@eschnett
Copy link
Contributor Author

The remaining failures seem unrelated.

tkf
tkf reviewed May 20, 2020
View reviewed changes
Copy link
Member

@tkf tkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost LGTM. If sacollect(::Type{<:StaticArray}, gen) works it'd be nice to have a few tests for MArray too.

src/SArray.jl Outdated Show resolved Hide resolved
src/SArray.jl Outdated Show resolved Hide resolved
src/SArray.jl Outdated Show resolved Hide resolved
@eschnett
Copy link
Contributor Author

The test failures seem unrelated.

tkf
tkf approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@tkf tkf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (still need to decide export sacollect #792 (comment))

@eschnett
Copy link
Contributor Author

All good now. Failures are unrelated.

@tkf tkf closed this May 23, 2020
@tkf tkf reopened this May 23, 2020
@tkf tkf merged commit 64c64b2 into JuliaArrays:master May 23, 2020
@tkf tkf mentioned this pull request Jun 15, 2020
Open
@tkf tkf mentioned this pull request Jul 8, 2020
Open
@kbarros kbarros mentioned this pull request Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

@tkf tkf tkf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide constructors that accept generators
4 participants
@eschnett @andyferris @tkf @KristofferC