Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some trait + LU api cleanup #695

Merged
merged 2 commits into from
Dec 8, 2019
Merged

Some trait + LU api cleanup #695

merged 2 commits into from
Dec 8, 2019

Conversation

c42f
Copy link
Member

@c42f c42f commented Nov 28, 2019

Implement .P property for LU factorizations now that this can be inferred. In the process of doing this I did some trait cleanup, as LU.U is triangular.

  • Add triangular matrix wrappers to StaticArrayLike
  • Avoid defining get() for our traits as that collides with Base.get

@c42f
Expand StaticArrayLike + some trait cleanup
d83e43f 
* Add triangular matrix wrappers to StaticArrayLike
* Avoid defining `get()` for our traits as that collides with Base.get
@c42f
Implement .P property for LU factorizations
0fd60a5 
This matches the Base API.
@c42f c42f added feature features and feature requests linear-algebra cleanup labels Nov 28, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 81.87% when pulling 0fd60a5 on cjf/lu-api-updates into d0f24c7 on master.

@c42f c42f merged commit 103e9d4 into master Dec 8, 2019
@c42f c42f deleted the cjf/lu-api-updates branch December 8, 2019 04:58
@c42f c42f mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cleanup feature features and feature requests linear-algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c42f @coveralls