Avoid calling promote_tuple_eltype in generated function to fix issue #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with promotion of user defined types.
|
Sounds fine to me. We are overdue for a new release but it will contain breaking changes so we'd need to backport this to release immediately. Easy enough, just some work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with promotion of user defined types. This is a minimal version of #670. I still think it would be beneficial to avoid generated functions when they aren't needed but it it's not urgent. In contrast this current issue is causing issues when using
StaticArrayswithForwardDiffso it would be useful to get fixed immediately. I'd appreciate if you could make a bugfix release after merging this.