Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexport the exported deprecation symbol centered #252

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

johnnychen94
Copy link
Member

Always forget that @deprecate will export the deprecated symbol by default.

This has introduced a symbol conflict in JuliaImages/ImageQualityIndexes.jl#36

This is a bug fix so I'll bump a patch version after merging.

@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #252 (705893f) into master (91ee03d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files           5        5           
  Lines         436      436           
=======================================
  Hits          416      416           
  Misses         20       20           
Impacted Files Coverage Δ
src/OffsetArrays.jl 98.29% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ee03d...705893f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant