add center/centered helpers #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnychen94
commented
May 22, 2021
| """ | ||
| function center(A::AbstractArray, r::RoundingMode=RoundDown) | ||
| map(axes(A)) do inds | ||
| round(Int, (length(inds)-1)/2, r) + first(inds) |
There was a problem hiding this comment.
The default RoundDown and length(inds)-1 is chosen to match the previous ImageFiltering.centered behavior:
julia> A = reshape(collect(1:6), 2, 3)
2×3 Matrix{Int64}:
1 3 5
2 4 6
julia> OffsetArrays.centered(A) == ImageFiltering.centered(A)
true
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 95.33% 95.37% +0.04%
==========================================
Files 5 5
Lines 407 411 +4
==========================================
+ Hits 388 392 +4
Misses 19 19
Continue to review full report at Codecov.
|
This was referenced May 22, 2021
jishnub
reviewed
May 23, 2021
jishnub
reviewed
May 23, 2021
| Sometimes, it will be convenient to shift the center coordinate of the given array to `(0, 0, ...)`, | ||
| `OffsetArrays.centered` is a helper for this very purpose: | ||
|
|
||
| ```@repl index |
There was a problem hiding this comment.
should these be doctests instead?
There was a problem hiding this comment.
The doctests are already in the src/ and test/ so I think it's okay to just follow the previous doc format here.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #169