Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguity in get_index (for tests) #13

Merged
merged 1 commit into from
May 22, 2023

Conversation

tanderson92
Copy link
Contributor

This fixes the following error:


RecurrenceMatrix: Error During Test at /home/thomas/Sync/OrthoPolySing/SingularIntegrals.jl/test/test_recurrence.jl:34
  Test threw exception
  Expression: r[100, :] ≈ r[100, 1:3]
  MethodError: getindex(::RecurrenceArray{Float64, 2, Vector{Float64}, Fill{Int64, 1, Tuple{InfiniteArrays.OneToInf{Int64}}}, Zeros{Int64, 1, Tuple{InfiniteArrays.OneToInf{Int64}}},

  Candidates:
    getindex(A::LazyArrays.AbstractCachedArray{T, 2} where T, k::Integer, jr::AbstractUnitRange)
      @ LazyArrays ~/.julia/packages/LazyArrays/oNvoa/src/cache.jl:104
    getindex(A::RecurrenceArray{T, 2, Z} where {T, Z<:(AbstractVector)}, k::Integer, jr::AbstractVector)
      @ SingularIntegrals ~/.julia/packages/SingularIntegrals/9azQG/src/recurrence.jl:159

  Possible fix, define
    getindex(::RecurrenceArray{T, 2, Z} where {T, Z<:(AbstractVector)}, ::Integer, ::AbstractUnitRange)

  Stacktrace:
   [1] macro expansion
     @ ~/Software/julia-1.9.0/share/julia/stdlib/v1.9/Test/src/Test.jl:478 [inlined]
   [2] macro expansion
     @ ~/Sync/OrthoPolySing/SingularIntegrals.jl/test/test_recurrence.jl:34 [inlined]
   [3] macro expansion
     @ ~/Software/julia-1.9.0/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
   [4] macro expansion
     @ ~/Sync/OrthoPolySing/SingularIntegrals.jl/test/test_recurrence.jl:28 [inlined]
   [5] macro expansion
     @ ~/Software/julia-1.9.0/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
   [6] top-level scope
     @ ~/Sync/OrthoPolySing/SingularIntegrals.jl/test/test_recurrence.jl:7
Test Summary:      | Pass  Error  Total  Time
RecurrenceArray    |   20      1     21  5.4s
  RecurrenceVector |   18            18  1.7s
  RecurrenceMatrix |    2      1      3  3.7s

@tanderson92
Copy link
Contributor Author

Status `~/.julia/environments/OrthoPolySing/Project.toml`
  [28f2ccd6] ApproxFun v0.13.20
  [aae01518] BandedMatrices v0.17.23
  [b30e2e7b] ClassicalOrthogonalPolynomials v0.8.1
  [7ae1f121] ContinuumArrays v0.12.6
  [5078a376] LazyArrays v1.1.1
  [d7e5e226] LazyBandedMatrices v0.8.9
  [c4ea9172] QuasiArrays v0.9.8
  [d7440221] SingularIntegrals v0.0.1 `~/Sync/OrthoPolySing/SingularIntegrals.jl`

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.25 ⚠️

Comparison is base (96fd60e) 89.75% compared to head (e1091e9) 89.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   89.75%   89.50%   -0.25%     
==========================================
  Files           5        5              
  Lines         322      324       +2     
==========================================
+ Hits          289      290       +1     
- Misses         33       34       +1     
Impacted Files Coverage Δ
src/recurrence.jl 96.73% <100.00%> (-1.07%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlfivefifty dlfivefifty merged commit cb20766 into JuliaApproximation:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants