Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isapprox for intervals which has been moved to IntervalSets #123

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

dlfivefifty
Copy link
Member

No description provided.

@daanhb daanhb mentioned this pull request Dec 2, 2022
@daanhb
Copy link
Member

daanhb commented Dec 3, 2022

It seems the tests failed due to an isapprox check. Since isapprox moved, perhaps we can also remove the test from DomainSets, tag a new release, and worry about the error being thrown elsewhere?

@dlfivefifty
Copy link
Member Author

OK agreed

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 86.09% // Head: 86.09% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (65fefcc) compared to base (8bce5e6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   86.09%   86.09%   -0.01%     
==========================================
  Files          31       31              
  Lines        2496     2495       -1     
==========================================
- Hits         2149     2148       -1     
  Misses        347      347              
Impacted Files Coverage Δ
src/domains/interval.jl 94.62% <ø> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlfivefifty dlfivefifty merged commit e3185fe into master Dec 5, 2022
@dlfivefifty dlfivefifty deleted the dl/removeisapprox branch December 5, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants