Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity Fun in normalized Polynomial spaces #91

Merged
merged 7 commits into from
Aug 19, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Aug 18, 2022

This allows one to obtain

julia> f = Fun(NormalizedLegendre(0..1))
Fun(NormalizedLegendre(0..1), [0.5, 0.28867513459481287])

julia> f(0.4)
0.4

On master, this falls back to using Chebyshev as the space. Such a construction should work as long as the conversion between the canonical and the normalized space is defined.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #91 (6743751) into master (b08b5aa) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   57.91%   58.15%   +0.24%     
==========================================
  Files          27       27              
  Lines        2414     2421       +7     
==========================================
+ Hits         1398     1408      +10     
+ Misses       1016     1013       -3     
Impacted Files Coverage Δ
src/Spaces/PolynomialSpace.jl 83.70% <100.00%> (+0.97%) ⬆️
src/Spaces/Chebyshev/Chebyshev.jl 55.07% <0.00%> (+0.72%) ⬆️
src/Spaces/Jacobi/Jacobi.jl 58.41% <0.00%> (+0.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jishnub jishnub changed the title Fun in normalized Polynomial spaces Identity Fun in normalized Polynomial spaces Aug 18, 2022
@jishnub jishnub merged commit b21e58f into JuliaApproximation:master Aug 19, 2022
@jishnub jishnub deleted the Funnormalizedspace branch August 19, 2022 05:20
jishnub added a commit to jishnub/ApproxFunOrthogonalPolynomials.jl that referenced this pull request Aug 19, 2022
* Fun in normalized polynomial spaces

* bump version to v0.4.17

* Add tests for Ultraspherical

* fix range construction

* actually add identity test

* add approx tolerances

* avoid shadowing variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant