Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial 5: Scaling #143

Closed
wants to merge 49 commits into from
Closed

Conversation

TheCedarPrince
Copy link
Member

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I update the TODO.md (if applicable)?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #126

How did you address these issues with this PR? What methods did you use?

@TheCedarPrince TheCedarPrince added the documentation Improvements or additions to documentation label Sep 3, 2020
@TheCedarPrince TheCedarPrince self-assigned this Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #143 into master will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   97.44%   97.66%   +0.22%     
==========================================
  Files           7        7              
  Lines         509      557      +48     
==========================================
+ Hits          496      544      +48     
  Misses         13       13              
Impacted Files Coverage Δ
src/Javis.jl 96.69% <100.00%> (+0.34%) ⬆️
src/luxor_overrides.jl 100.00% <100.00%> (ø)
src/subaction_animations.jl 100.00% <100.00%> (ø)
src/util.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed529d7...60179d9. Read the comment docs.

CHANGELOG.md Outdated
@@ -1,5 +1,8 @@
# Javis.jl - Changelog

## Unreleased v0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you created the branch from the wrong base branch 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea... Just realized that I did that... Fixed now however!

@Wikunia
Copy link
Member

Wikunia commented Sep 10, 2020

You merged v0.2 into it but it should go to master 😛

@TheCedarPrince TheCedarPrince marked this pull request as ready for review September 10, 2020 17:36
@Wikunia Wikunia deleted the tcp-documentation-scaling-tut branch September 17, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial: Scaling
2 participants