Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale parameter for funnel #134

Merged
merged 4 commits into from
Sep 20, 2023
Merged

scale parameter for funnel #134

merged 4 commits into from
Sep 20, 2023

Conversation

miguelbiron
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #134 (2b37186) into main (5f1520d) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files          81       81           
  Lines        2259     2259           
=======================================
  Hits         1929     1929           
  Misses        330      330           
Files Changed Coverage Δ
src/targets/toy_stan_target.jl 84.61% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@miguelbiron
Copy link
Collaborator Author

Hmm it seems that the strict keyword for makedocs was removed in Documenter v1.

@miguelbiron
Copy link
Collaborator Author

Oh it seems that failing on missing docstrings is now the default so the keyword is not required

By default, if the document check detect any errors, it will fail the documentation build. This behavior can be relaxed with the warnonly keyword.

https://documenter.juliadocs.org/stable/lib/public/#Documenter.makedocs

@miguelbiron
Copy link
Collaborator Author

Going to merge regardless of failed CI since that is unrelated to this pr

@miguelbiron miguelbiron merged commit d2c4ec8 into main Sep 20, 2023
9 of 10 checks passed
@miguelbiron miguelbiron deleted the funnel-scale branch September 20, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants