Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to work in shimmed browsers #14

Closed
miyconst opened this issue Jan 14, 2016 · 6 comments
Closed

Update examples to work in shimmed browsers #14

miyconst opened this issue Jan 14, 2016 · 6 comments
Assignees

Comments

@miyconst
Copy link

Right now lots of juicy-html examples use document.currentScript which is supported in Chrome only.

Have to be replaced with (document._currentScript || document.currentScript).

@miyconst miyconst self-assigned this Jan 14, 2016
@tomalec
Copy link
Member

tomalec commented Jan 14, 2016

👍 good catch

miyconst pushed a commit that referenced this issue Jan 20, 2016
@miyconst
Copy link
Author

I have formatted and fixed juicy-html/examples, but those two still don't work under IE;

http://juicy.github.io/juicy-html/examples/inline_markup_w_model_binding.html
http://juicy.github.io/juicy-html/examples/polymer_template_inline.html

Because both currentScript and _currentScript are not set in IE.

@tomalec can you take a look?

And I have to test in Edge & Safari. Works in Chrome & FF.

@tomalec
Copy link
Member

tomalec commented Jan 20, 2016

@miyconst
Copy link
Author

Yeah.. and it works in FF, but not in IE.

Edge will be tested tonight, don't have latest version at office.

@miyconst
Copy link
Author

miyconst commented Mar 1, 2016

Edge tested - works.

@miyconst
Copy link
Author

There is nothing can be done in juicy-html to fix the examples. This issue should be fixed: This issue requires Juicy/imported-template#21.

Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants