Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into master for new release v.1.2.0 #126

Merged
merged 278 commits into from
Jun 7, 2021
Merged

Merge develop into master for new release v.1.2.0 #126

merged 278 commits into from
Jun 7, 2021

Conversation

broeder-j
Copy link
Member

No description provided.

janssenhenning and others added 30 commits January 17, 2021 13:38
-Only routines with no explicit xpath need it
Now the xml_util routines can be modified one by one
- path_spec argument added to specify path with contains not_contains arguments
- shift_value tests fail since the test input file is Max4 and there are many attributes denoted as string which were expected to be float
…er function

This function is much more general and uses the information in the schema dictionary to correctly handle all cases and if it needs to recursively goes deeper to set more complex constructs
- Same problem as for shift_value the input file for the tests need to be moved to max5
The kpoint paths and list forms of MaXR5 have changed.
For now I adjusted the path. Fleurinpdata might be back compatible.
Fixed pretty print of fleurinpmodifier show, since to string returns a
bit string, which was not converted for python3. Also paths for dos
switches. This is not backcompatible, without xpaths from schema files.
Support for MaXR5, not all green. Main workflows run. Important for iffaiida tutorial
before they were stored as attributes in the database.
Also now if we clone a fleurinp data node it will update the search paths of the new one
and if the schema file of the old one is not available it will search for a new one.
@broeder-j broeder-j changed the title Merge develop into master for new release Merge develop into master for new release v.1.2.0 Jun 2, 2021
Add some error messages to prevent kpoint paths being used for DOS calculations
And do not switch the kpoint set by default for DOS calculations
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #126 (cac7ddf) into master (8ef56cb) will decrease coverage by 2.44%.
The diff coverage is 53.86%.

❗ Current head cac7ddf differs from pull request most recent head 37bae04. Consider uploading reports for the commit 37bae04 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   68.57%   66.12%   -2.45%     
==========================================
  Files          71      119      +48     
  Lines       10501    12434    +1933     
==========================================
+ Hits         7201     8222    +1021     
- Misses       3300     4212     +912     
Impacted Files Coverage Δ
aiida_fleur/common/defaults.py 0.00% <ø> (ø)
aiida_fleur/common/node_generators.py 0.00% <0.00%> (ø)
aiida_fleur/workflows/ssdisp_conv.py 23.62% <ø> (ø)
tests/calculation/test_inpgen.py 85.18% <ø> (ø)
tests/conftest.py 70.13% <ø> (ø)
tests/data/test_fleurinp.py 100.00% <ø> (ø)
tests/data/test_fleurinpmodifier.py 100.00% <ø> (ø)
tests/parsers/test_fleur_parser.py 96.22% <ø> (ø)
tests/test_calcfunctions_immutabledefaults.py 92.00% <ø> (ø)
tests/test_entrypoints.py 100.00% <ø> (ø)
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef56cb...37bae04. Read the comment docs.

@broeder-j
Copy link
Member Author

broeder-j commented Jun 4, 2021

I do not understand the current error in the CI with the docs build. Locally I have no problems. But there I also have a different python version...

Readthedocs builds fine ignores this exception. But the sphinx-click extension is not working there for the CLI

@janssenhenning
Copy link
Contributor

janssenhenning commented Jun 4, 2021

@broeder-j Simply adding reentry scan seems to help. I would also switch the docs build to python 3.8, since I had some problems with python 3.7 and sphinx 4.0 for masci-tools. For example unordered lists are not shown correctly (e.g https://aiida-fleur.readthedocs.io/en/latest/devel_guide/dg_index.html)

EDIT: Problem is I don't know how you would add the reentry scan to the read the docs build, since it does not really support arbitrary commands (But we can probably access reentry scan via python directly in the conf.py file)

add reentry scan after dependency installations since sphinx-click fails otherwise and move to python 3.8 since sphinx 4.0 has some problems for python 3.7
@broeder-j
Copy link
Member Author

@janssenhenning Thx

@broeder-j broeder-j merged commit 652570a into master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants