Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overlay config after overlay.repaint #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Oscar-ren
Copy link
Contributor

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch vx.x.x.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:
if** isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.

Update overlay config after overlay.repaint

Such as Marker:

Usually Marker.repaint will update the Marker.overlay.config, but Marker.config not update.

This will cause Marker.point change but position not change,
finally call Marker.setPosition(oldPosition), the Marker don't move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant