fix: #83

There is no changed Event in diffConfig, the bound event will be removed
JserWang · Jan 21, 2019 · 1c0fce7 · 1c0fce7
1 parent d412239
commit 1c0fce7
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 14 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rc-bmap",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "main": "lib/index.js",
   "repository": {
     "type": "git",

diff --git a/src/core/AutoComplete/index.js b/src/core/AutoComplete/index.js
@@ -42,12 +42,9 @@ class AutoComplete {
       this.init({ ...this.config, ...diffConfig });
     } else {
       this.processOptions(diffConfig);
-
-      if (config.events) {
-        this.processEvents(config.events);
-      }
     }
     this.config = { ...this.config, ...diffConfig };
+    this.processEvents(this.config.events);
   }
 
   destroy = () => {
@@ -56,9 +53,7 @@ class AutoComplete {
 
   processEvents = (events) => {
     Util.unbindEvents(this.instance);
-    if (events) {
-      Util.bindEvents(this.instance, events);
-    }
+    Util.bindEvents(this.instance, events);
   }
 
   processOptions(config) {

diff --git a/src/core/Map/index.js b/src/core/Map/index.js
@@ -98,14 +98,13 @@ class Map {
     const diffConfig = Util.compareConfig(this.config, config);
 
     this.processContextMenu(diffConfig.contextMenu);
-    this.processEvents(diffConfig.events);
-
     this.setMapType(diffConfig.mapType);
     this.processOptions(diffConfig);
     this.config = {
       ...this.config,
       ...diffConfig,
     };
+    this.processEvents(this.config.events);
   }
 }
 

diff --git a/src/core/Overlay/BaseOverlay.js b/src/core/Overlay/BaseOverlay.js
@@ -27,12 +27,9 @@ class BaseOverlay {
       this.init({ ...this.config, ...diffConfig });
     } else {
       this.processOptions(diffConfig);
-
-      if (config.events) {
-        this.processEvents(config.events);
-      }
     }
     this.config = { ...this.config, ...diffConfig };
+    this.processEvents(this.config.events);
   }
 
   destroy = () => {