Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #922 Scientific notation format #923

Closed
wants to merge 1 commit into from

Conversation

sviatcraft
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #922

What is the new behavior?

Scientific notation numbers are being handled as expected
e.g. 4e-7 is displayed as 0.0000004

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@NepipenkoIgor
Copy link
Collaborator

@sviatcraft Thank you for PR . Could you add more unit tests ?

@NepipenkoIgor
Copy link
Collaborator

@sviatcraft Hi .Could. you add test for this issue ?

@NepipenkoIgor
Copy link
Collaborator

@sviatcraft Hi. Looks like the latest changes broke the whole library . Needed to revert and repeat all from scratch. Please make reverse merge from actual develop

@NepipenkoIgor
Copy link
Collaborator

@sviatcraft Hi . Please fix errors. Check CI logs

@sviatcraft
Copy link
Author

@NepipenkoIgor I will resolve errors.
I did try to add unit tests but failed, had strange behavior. Will try again.
I think sometime next week will push updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants