Migrate the 'chain-spec-builder' utility project to the Substrate 2.0.0rc4 #1148
Conversation
- removed all traces of the pallet_contracts (runtime, rpc, node, chain_spec) - fix load_spec TODO
| @@ -10,8 +10,8 @@ | |||
| //! | |||
| //! ## Supported extrinsics | |||
| //! | |||
| //! - [set_ipns_id](./struct.Module.html#method.set_ipns_id) - Creates the AccountInfo to save an IPNS identity for the storage provider. | |||
| //! - [unset_ipns_id](./struct.Module.html#method.unset_ipns_id) - Deletes the AccountInfo with the IPNS identity for the storage provider. | |||
| //! - [set_ipns_id](./struct.Module.html#method.set_ipns_id) - Creates the StorageProviderAccountInfo to save an IPNS identity for the storage provider. | |||
There was a problem hiding this comment.
I understand the need to change the name here because it conflicts with the balances::AccountInfo struct. And I recommend a better name of ServiceProviderRecord because it shouldn't be storage provider specific. I'm not sure how much longer we will keep this module around or if it will be used by other services, but until then we might as well use a general name.
There was a problem hiding this comment.
types library is prepared with this requested change #1153
This is the only change request otherwise ready to merge. 👍
|
There is one piece of useful information which we seem to have lost now which is the commit hash in the version string like: Is it possible to add it back? |
|
I restored the node version from the environment variable. |
Features:
chain-spec-builderutility to the Substrate 2.0.0rc4pallet_contractswere removed (runimte, rpc, node, chain-spec-builder)AccountInfoin theservice-discoverywas renamed toStorageProviderAccountInfobuild.rsscripts in the runtime and node projects.