fix: Default value for NGINX_PROXY_HEADER_Host is $http_host

Remove the Proxy header from default.conf fixes #113
Joxit · Jan 19, 2020 · 8b7bd6c · 8b7bd6c
1 parent f56cd05
commit 8b7bd6c
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -61,6 +61,8 @@ This web user interface uses [Riot](https://github.com/Riot/riot) the react-like
     -   Yes you can, you must first configure your docker client. (see [#76](https://github.com/Joxit/docker-registry-ui/issues/76))
 -   What does Mixed Content error mean ?
     -   This means you are using a UI with HTTPS and your registry is using HTTP (unsecured). When you are on a HTTPS site, you can't get HTTP content. Upgrade you registry with a HTTPS connection.
+-   Why the default nginx `Host` is set to `$http_host` ?
+    -   This fixes the issue [#88](https://github.com/Joxit/docker-registry-ui/issues/88). More about this in [#113](https://github.com/Joxit/docker-registry-ui/issues/113).
 
 Need more informations ? Try my [examples](https://github.com/Joxit/docker-registry-ui/tree/master/examples) or open an issue.
 

diff --git a/arm32v7-static.dockerfile b/arm32v7-static.dockerfile
@@ -18,6 +18,8 @@ LABEL maintainer="Jones MAGLOIRE @Joxit"
 
 WORKDIR /usr/share/nginx/html/
 
+ENV NGINX_PROXY_HEADER_Host '$http_host'
+
 COPY nginx/default.conf /etc/nginx/conf.d/default.conf
 COPY dist/ /usr/share/nginx/html/
 COPY dist/scripts/docker-registry-ui-static.js /usr/share/nginx/html/scripts/docker-registry-ui.js

diff --git a/arm64v8-static.dockerfile b/arm64v8-static.dockerfile
@@ -18,6 +18,8 @@ LABEL maintainer="Jones MAGLOIRE @Joxit"
 
 WORKDIR /usr/share/nginx/html/
 
+ENV NGINX_PROXY_HEADER_Host '$http_host'
+
 COPY nginx/default.conf /etc/nginx/conf.d/default.conf
 COPY dist/ /usr/share/nginx/html/
 COPY dist/scripts/docker-registry-ui-static.js /usr/share/nginx/html/scripts/docker-registry-ui.js

diff --git a/debian-static.dockerfile b/debian-static.dockerfile
@@ -18,6 +18,8 @@ LABEL maintainer="Jones MAGLOIRE @Joxit"
 
 WORKDIR /usr/share/nginx/html/
 
+ENV NGINX_PROXY_HEADER_Host '$http_host'
+
 COPY nginx/default.conf /etc/nginx/conf.d/default.conf
 COPY dist/ /usr/share/nginx/html/
 COPY dist/scripts/docker-registry-ui-static.js /usr/share/nginx/html/scripts/docker-registry-ui.js

diff --git a/dist/scripts/docker-registry-ui-static.js b/dist/scripts/docker-registry-ui-static.js
diff --git a/dist/scripts/docker-registry-ui.js b/dist/scripts/docker-registry-ui.js
diff --git a/nginx/default.conf b/nginx/default.conf
@@ -24,7 +24,6 @@ server {
 #!        if ($http_user_agent ~ "^(docker\/1\.(3|4|5(?!\.[0-9]-dev))|Go ).*$" ) {
 #!            return 404;
 #!        }
-#!        proxy_set_header Host $http_host;
 #!        ${NGINX_PROXY_HEADERS}
 #!        proxy_pass ${REGISTRY_URL};
 #!    }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "docker-registry-ui",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "scripts": {
     "build": "./node_modules/gulp/bin/gulp.js build"
   },

diff --git a/static.dockerfile b/static.dockerfile
@@ -30,6 +30,8 @@ LABEL maintainer="Jones MAGLOIRE @Joxit"
 
 WORKDIR /usr/share/nginx/html/
 
+ENV NGINX_PROXY_HEADER_Host '$http_host'
+
 COPY nginx/default.conf /etc/nginx/conf.d/default.conf
 COPY --from=builder /usr/app/dist/ /usr/share/nginx/html/
 COPY --from=builder /usr/app/dist/scripts/docker-registry-ui-static.js /usr/share/nginx/html/scripts/docker-registry-ui.js