Merge branch 'main' into update_0.2.4

JosiahParry · Feb 26, 2024 · 1513402 · 1513402
2 parents e6a79d2 + 7528b99
commit 1513402
Show file tree

Hide file tree

Showing 128 changed files with 572 additions and 381 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,12 +1,12 @@
 Package: sfdep
 Title: Spatial Dependence for Simple Features
 Version: 0.2.4
-Authors@R: 
-    person(given = "Josiah",
-           family = "Parry",
-           role = c("aut", "cre"),
-           email = "[email protected]",
-           comment = c(ORCID = "0000-0001-9910-865X"))
+Authors@R: c(
+    person("Josiah", "Parry", , "[email protected]", role = c("aut"),
+           comment = c(ORCID = "0000-0001-9910-865X")),
+    person("Dexter", "Locke", 'H', "[email protected]", role = c("aut", "cre"),
+           comment = c(ORCID = "0000-0003-2704-9720"))
+  )
 Description: An interface to 'spdep' to integrate with 'sf' objects and the 'tidyverse'.
 License: GPL-3
 URL: https://sfdep.josiahparry.com, https://github.com/josiahparry/sfdep
@@ -45,4 +45,3 @@ Imports:
 Depends: 
     R (>= 3.5.0)
 LazyData: true
-
diff --git a/NAMESPACE b/NAMESPACE
@@ -1,5 +1,7 @@
 # Generated by roxygen2: do not edit by hand
 
+S3method("[",spacetime)
+S3method("[[",spacetime)
 S3method(activate,spacetime)
 S3method(as_spacetime,sf)
 S3method(print,spacetime)

diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,9 @@
 # sfdep 0.2.4
 
 - updated spacetime_constructor to comply with updates to the cli package. No user-facing changes
+- Dexter Locke [@DHLocke] is now the maintainer of sfdep
+- Address failing CRAN checks h/t [@rsbivand](https://github.com/rsbivand) <https://github.com/JosiahParry/sfdep/pull/43>
+- Address bug in local Gi/* statistics
 
 # sfdep 0.2.3
 

diff --git a/R/spacetime-methods.R b/R/spacetime-methods.R
@@ -2,11 +2,12 @@
 # Selection ---------------------------------------------------------------
 # Selection method
 # to do  update `times` attribute when subset and data is active
-
+#' @export
 `[.spacetime` <- function(x, ...) {
   NextMethod()
 }
 
+#' @export
 `[[.spacetime` <- function(x, ...) {
   NextMethod()
 }

diff --git a/README.md b/README.md
@@ -1,5 +1,3 @@
-# In need of a new maintainer!
-
 <!-- README.md is generated from README.Rmd. Please edit that file -->
 
 # sfdep

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,5 +1,8 @@
 ## R CMD check results
 
-Package was archived yesterday, 2023-01-09, despite efforts to address outstanding issues. 
+0 errors | 0 warnings | 0 note
 
-Latest submission failed the recursive `noSuggest` check. An example using an imported package (sf) failed because the imported function (sf::read_sf) used a suggested package (tibble suggested by sf). All instances of `sf::read_sf()` have been changed to `sf::st_read()` which, I believe, does not use any suggested packages. 
+* This release removes myself (Josiah Parry) as the maintainer and makes 
+  Dexter Locke the new maintainer of sfdep. 
+  * CRAN has been notified of this in previous correspondence via email
+* Addresses failing noSuggests checks
diff --git a/docs/404.html b/docs/404.html
diff --git a/docs/CONTRIBUTING.html b/docs/CONTRIBUTING.html
diff --git a/docs/LICENSE.html b/docs/LICENSE.html
diff --git a/docs/articles/Version-0-2-0.html b/docs/articles/Version-0-2-0.html
diff --git a/docs/articles/Version-0-2-0_files/figure-html/unnamed-chunk-10-1.png b/docs/articles/Version-0-2-0_files/figure-html/unnamed-chunk-10-1.png
diff --git a/docs/articles/Version-0-2-0_files/figure-html/unnamed-chunk-11-1.png b/docs/articles/Version-0-2-0_files/figure-html/unnamed-chunk-11-1.png
diff --git a/docs/articles/Version-0-2-0_files/figure-html/unnamed-chunk-8-1.png b/docs/articles/Version-0-2-0_files/figure-html/unnamed-chunk-8-1.png