Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dev dependencies #341

Merged
merged 7 commits into from
Dec 24, 2023
Merged

chore: update dev dependencies #341

merged 7 commits into from
Dec 24, 2023

Conversation

RebeccaStevens
Copy link
Collaborator

PR Checklist

Overview

Updates all the dev deps to the latest versions.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f12728a) 80.22% compared to head (5992d4f) 80.22%.

Files Patch % Lines
src/usage/getPropertyName.ts 0.00% 2 Missing ⚠️
src/usage/UsageWalker.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          35       35           
  Lines        6406     6406           
  Branches      360      360           
=======================================
  Hits         5139     5139           
  Misses       1267     1267           
Flag Coverage Δ
4.3.5 80.00% <25.00%> (ø)
4.6.4 80.03% <25.00%> (ø)
4.9.5 80.03% <25.00%> (ø)
latest 80.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RebeccaStevens
Copy link
Collaborator Author

Not sure why knip is complaining. @JoshuaKGoldberg Do want to investigate?

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

"entry": ["src/**/index.ts!"],
"ignore": [
// https://github.com/JoshuaKGoldberg/ts-api-utils/issues/343
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#341 (comment) 🤷 I couldn't figure it out and don't want to be blocked on it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 5081005 into main Dec 24, 2023
23 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the deps-update branch December 24, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants