Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add understanding of more commit types #112

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

In addition to adding in commit types like build: and ci:, I also enhanced the granularity of commit type checking in a new getCommitMeaning function. This way commits like feat: bump some dependency to 1.2.3 still count as meaningful. Previously they would have first been hit by isReleaseCommit.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #112 (1d1acc2) into main (d746446) will increase coverage by 27.60%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##            main     #112       +/-   ##
==========================================
+ Coverage   7.69%   35.29%   +27.60%     
==========================================
  Files          4        4               
  Lines         26       34        +8     
  Branches       4        8        +4     
==========================================
+ Hits           2       12       +10     
+ Misses        24       22        -2     
Files Coverage Δ
src/getCommitMeaning.ts 100.00% <100.00%> (ø)
src/shouldSemanticRelease.ts 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit c7e619b into main Oct 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the more-commit-meanings branch October 2, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add more ignored commits
1 participant