Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't require version or name if package has "private": true #87

Merged

Conversation

hyoban
Copy link
Contributor

@hyoban hyoban commented Apr 11, 2024

fix #84

@hyoban
Copy link
Contributor Author

hyoban commented May 1, 2024

@JoshuaKGoldberg Hi, Can you help me take a look at this PR?

hyoban added a commit to hyoban/eslint-config-hyoban that referenced this pull request Jun 21, 2024
@hyoban
Copy link
Contributor Author

hyoban commented Jul 5, 2024

Sorry to ping @JoshuaKGoldberg again.

@JoshuaKGoldberg
Copy link
Owner

OH! Oh no! I'm very sorry to leave you hanging on this, I have no idea how I missed multiple notifications!

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Clear implementation & tests, nicely done. ⚡

@JoshuaKGoldberg JoshuaKGoldberg merged commit ac9e830 into JoshuaKGoldberg:master Jul 6, 2024
@JoshuaKGoldberg
Copy link
Owner

Published in [email protected]. Thanks @hyoban! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Don't require version if package has "private": true
2 participants