Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for catalog:, npm:, and workspace: protocol #103

Conversation

michaelfaith
Copy link
Contributor

@michaelfaith michaelfaith commented Dec 26, 2024

PR Checklist

Overview

This change adds support for pnpm's catalog: protocol as well as yarn and pnpm's workspace protocol. Catalog entries can be simply catalog: or include a named catalog record (e.g. catalog:react19). Workspace, can just be workspace: or workspace with a range specifier (workspace:^) or workspace and a specific version range (workspace:^1.50).

Workspace protocol: https://pnpm.io/next/workspaces#workspace-protocol-workspace
Catalog: https://pnpm.io/next/catalogs

Closes #71 (and possible JoshuaKGoldberg/eslint-plugin-package-json#509)

@michaelfaith michaelfaith force-pushed the fix/support-catalog-and-workspace-protocol branch from acd2ef5 to 44276e3 Compare December 26, 2024 18:39
@michaelfaith michaelfaith changed the title fix: add support for catalog: and workspace: protocol fix: add support for catalog:, npm:, and workspace: protocol Dec 26, 2024
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, thanks! 🎉

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Dec 30, 2024
This change adds support for pnpm's catalog: protocol as well as yarn and pnpm's workspace protocol.
Catalog entries can be simply `catalog:` or include a named catalog record (e.g. `catalog:react19`).  Workspace, can just be `workspace:` or workspace with a range specifier (`workspace:^`) or workspace and a specific version range (`workspace:^1.50`).

Workspace protocol: https://pnpm.io/next/workspaces#workspace-protocol-workspace
Catalog: https://pnpm.io/next/catalogs
@michaelfaith michaelfaith force-pushed the fix/support-catalog-and-workspace-protocol branch from 44276e3 to a7fcd4f Compare December 30, 2024 17:34
@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Dec 31, 2024
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit 91c139a into JoshuaKGoldberg:main Dec 31, 2024
5 checks passed
Copy link

🎉 This is included in version v0.7.3 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Support version protocols: npm:, workspace:, etc.
2 participants