Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Error: could not determine executable to run #100

Closed
3 tasks done
rgant opened this issue Nov 26, 2024 · 8 comments · Fixed by #101
Closed
3 tasks done

🐛 Bug: Error: could not determine executable to run #100

rgant opened this issue Nov 26, 2024 · 8 comments · Fixed by #101
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛

Comments

@rgant
Copy link
Contributor

rgant commented Nov 26, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

When running npx package-json-validator --warnings --recommendations I expect to install temporarily this package and then run the validator.

Actual

I get the following error:

npm error could not determine executable to run

Additional Info

I believe that this is caused by the removal of the bin key in the package.json by #89.

Can we restore this key and see if that works?

@rgant rgant added the type: bug Something isn't working :( 🐛 label Nov 26, 2024
@rgant
Copy link
Contributor Author

rgant commented Nov 26, 2024

Logs:

14 http fetch GET 200 https://registry.npmjs.org/package-json-validator 132ms (cache revalidated)
15 verbose stack Error: could not determine executable to run
15 verbose stack     at getBinFromManifest (/opt/homebrew/lib/node_modules/npm/node_modules/libnpmexec/lib/get-bin-from-manifest.js:17:23)
15 verbose stack     at exec (/opt/homebrew/lib/node_modules/npm/node_modules/libnpmexec/lib/index.js:202:15)
15 verbose stack     at async Npm.exec (/opt/homebrew/lib/node_modules/npm/lib/npm.js:207:9)
15 verbose stack     at async module.exports (/opt/homebrew/lib/node_modules/npm/lib/cli/entry.js:74:5)
16 verbose pkgid [email protected]

@bramus
Copy link

bramus commented Dec 17, 2024

Ran into the same thing just now.

I see a PR for this is up. Could you take a look into merging it @JoshuaKGoldberg, pretty please?

@bramus
Copy link

bramus commented Dec 17, 2024

To other folks finding this issue: awaiting the PR getting merged, you can run @rgant’s fork with fix directly using the following command:

npx github:rgant/package-json-validator#add-package-bin

@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! 🙏 label Dec 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 17, 2024
@JoshuaKGoldberg
Copy link
Owner

Puss in Boots suddenly becoming very very afraid

Oh! Sorry, I dropped this notification. Will fix now!

@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @rgant for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @rgant! 🎉

Copy link

🎉 This is included in version v0.7.1 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this issue Dec 17, 2024
Adds @rgant as a contributor for bug.

This was requested by JoshuaKGoldberg [in this
comment](#100 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@JoshuaKGoldberg JoshuaKGoldberg removed their assignment Dec 17, 2024
@bramus
Copy link

bramus commented Dec 17, 2024

Thank you, kind Sir!

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants