fix: account for base when suggesting rerun cmd

[GV14982]

PR Checklist

• Addresses an existing open issue: fixes 🐛 Bug: Rerun suggestions don't factor in --base #905
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Add additional filter logic to check if an options entry was excluded by the base, and filter it out of the suggested rerun flags, add new test, update failing test with suggestion from jest

(>^u^)><(^u^)><(^u^<)

[codecov]

Codecov Report

Merging #992 (9d9f6bd) into main (6c15440) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   94.10%   94.12%   +0.02%     
==========================================
  Files          95       95              
  Lines        5428     5448      +20     
  Branches      431      436       +5     
==========================================
+ Hits         5108     5128      +20     
  Misses        319      319              
  Partials        1        1              

Flag	Coverage Δ
create	70.85% <59.52%> (+0.11%)	⬆️
initialize	41.13% <59.52%> (+0.22%)	⬆️
migrate	69.83% <59.52%> (+0.11%)	⬆️
unit	71.58% <100.00%> (+0.12%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/create/createRerunSuggestion.ts	100.00% <100.00%> (ø)
src/shared/options/augmentOptionsWithExcludes.ts	73.14% <100.00%> (+1.15%)	⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[GV14982]

I am not entirely sure why this is failing compliance checks?

[JoshuaKGoldberg]

From the failure linked in the ❌: https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/6690991139/job/18177354788?pr=992:

Error: This PR's title should conform to specification at https://conventionalcommits.org/

bug: is a prefix for an issue; fix: would be the right title for a PR. A few linked issues that I hope will eventually make the explanations better:

• 🐛 Bug: Compliance bot isn't posting comments on PRs from forks #732
• Give a better error than "Resource not accessible by integration" when permissions lacking mtfoley/pr-compliance-action#368 -> feat: friendly error messages, add review comment output mtfoley/pr-compliance-action#374
• Feature: Suggest a corrected PR title if determinable? mtfoley/pr-compliance-action#367

[JoshuaKGoldberg]

Wonderful, thanks! This will make my life a bit easier for #734 😄

Not much to change, the core logic is looking great. Just a few small touchups. What do you think?

[JoshuaKGoldberg]

Great, thanks! Just one small nitpick on the opts variable name - I can merge in a few days if you don't have strong objection to renaming.

[JoshuaKGoldberg]

👋 @GV14982 still interested in the opts rename? No worries if not, I just don't want to rudely take over 😄

[GV14982]

Oh sorry, I misunderstood your earlier comment. Yeah by all means!

[github-actions]

🎉 This is included in version v1.43.1 🎉

The release is available on:

• GitHub releases
• npm package (@latest dist-tag)

Cheers! 📦🚀