-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --exclude-* with a fallback prompt #695
Conversation
Codecov Report
@@ Coverage Diff @@
## main #695 +/- ##
==========================================
- Coverage 95.22% 91.74% -3.48%
==========================================
Files 82 79 -3
Lines 3730 3818 +88
Branches 173 205 +32
==========================================
- Hits 3552 3503 -49
- Misses 178 314 +136
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
"ignoreDependencies": [ | ||
// https://github.com/webpro/knip/issues/207 | ||
"c8" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat unrelated 😄 but while I'm here...
I'll file issues for adding more test coverage and other followups. This PR is great for adding |
🎉 This is included in version v1.29.4 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
Drastically streamlines and simplifies the way defaults/overrides are provided to
readInputs
. In fact, they're no longer take in at all - all three setup scripts now use the same kinds of default gathering! This way they all use whatever information is available to them. Updates the docs to reflect this standardization.Renames
lint:package
tolint:package-json
.--exclude-lint-package
was too visually similar to--exclude-lint-packages
for comfort.Adds a
--base
CLI flag that can be set as"everything"
,"minimal"
, or"prompt"
.