Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --exclude-* with a fallback prompt #695

Merged
merged 31 commits into from
Aug 25, 2023
Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 23, 2023

PR Checklist

Overview

Drastically streamlines and simplifies the way defaults/overrides are provided to readInputs. In fact, they're no longer take in at all - all three setup scripts now use the same kinds of default gathering! This way they all use whatever information is available to them. Updates the docs to reflect this standardization.

Renames lint:package to lint:package-json. --exclude-lint-package was too visually similar to --exclude-lint-packages for comfort.

Adds a --base CLI flag that can be set as "everything", "minimal", or "prompt".

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #695 (dc8b545) into main (4bab59f) will decrease coverage by 3.48%.
The diff coverage is 86.20%.

@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   95.22%   91.74%   -3.48%     
==========================================
  Files          82       79       -3     
  Lines        3730     3818      +88     
  Branches      173      205      +32     
==========================================
- Hits         3552     3503      -49     
- Misses        178      314     +136     
- Partials        0        1       +1     
Flag Coverage Δ
create 75.35% <74.96%> (+1.53%) ⬆️
initialize 34.24% <28.70%> (-1.12%) ⬇️
migrate 74.70% <73.03%> (-0.60%) ⬇️
unit 35.29% <25.64%> (-3.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/shared/cli/spinners.ts 75.86% <ø> (-3.55%) ⬇️
src/shared/options/getOctokit.ts 100.00% <ø> (ø)
src/shared/runOrRestore.ts 100.00% <ø> (ø)
src/shared/types.ts 0.00% <0.00%> (ø)
...HubRepository/labels/getExistingEquivalentLabel.ts 100.00% <ø> (ø)
...initializeGitHubRepository/labels/outcomeLabels.ts 100.00% <ø> (ø)
src/steps/initializeGitHubRepository/index.ts 46.66% <46.66%> (ø)
src/shared/options/augmentOptionsWithExcludes.ts 62.50% <62.50%> (ø)
src/create/createWithOptions.ts 73.77% <73.77%> (ø)
src/shared/options/readGitAndNpmDefaults/index.ts 75.00% <75.00%> (ø)
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

"ignoreDependencies": [
// https://github.com/webpro/knip/issues/207
"c8"
],
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat unrelated 😄 but while I'm here...

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 24, 2023 16:07
@JoshuaKGoldberg
Copy link
Owner Author

I'll file issues for adding more test coverage and other followups. This PR is great for adding good first issues!

@JoshuaKGoldberg JoshuaKGoldberg merged commit a386c87 into main Aug 25, 2023
14 of 16 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the exclusions branch August 25, 2023 12:25
@github-actions
Copy link

🎉 This is included in version v1.29.4 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add CLI prompt for removing parts of the template
1 participant