Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Knip schema should be synced to the package's specific version #1638

Open
3 tasks done
JoshuaKGoldberg opened this issue Aug 16, 2024 · 4 comments
Open
3 tasks done
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

There should be no dependencies in this project on external network requests for core dev functionality.

Actual

"$schema": "https://unpkg.com/knip@latest/schema.json",

Additional Info

@atilafassina mentioned this to me in DM and I agree.

💖

Co-authored-by: @atilafassina

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Aug 16, 2024
@atilafassina
Copy link

The reasoning is that unpkg is hardcoded to latest, so it can go out-of-sync if there's a change in schema for a future version and the client app isn't up-to-date.

But using node_modules can be tricky if CTA is used in a monorepo context.

So, perhaps the default should be the sibling node_modules but there should be a new prompt asking for a the node_modules path.

@JoshuaKGoldberg JoshuaKGoldberg changed the title 🐛 Bug: Knip schema should come from node_modules, not unpkg 🐛 Bug: Knip schema should be synced to the package's specific version Aug 16, 2024
@JoshuaKGoldberg
Copy link
Owner Author

Yeah monorepo context is ... hard. #1064 is still pending. For now I think it's fine to not support it.

For visibility, I plan on doing a big overhaul in #1181 and monorepo support is not going to happen this year.

@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @atilafassina for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @atilafassina! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this issue Aug 16, 2024
Adds @atilafassina as a contributor for bug.

This was requested by JoshuaKGoldberg [in this
comment](#1638 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

2 participants