Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Use ESLint flat config #1212

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 9, 2024 · 6 comments · Fixed by #1457
Closed
3 tasks done

🚀 Feature: Use ESLint flat config #1212

JoshuaKGoldberg opened this issue Jan 9, 2024 · 6 comments · Fixed by #1457
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
General Simplific...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

https://eslint.org/docs/latest/use/configure/configuration-files-new: ESLint's new "flat config" format is going to be the main -> only way to configure ESLint soon. So this template should use that!

Additional Info

Adding to the General Simplification milestone as it'd allow the repo to get rid of the .eslintignore file.

...and also marking this as blocked on typescript-eslint supporting ESLint flat config. Which we're still blocked on as of filing this issue. typescript-eslint/typescript-eslint#7694
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: blocked Waiting for something else to be resolved labels Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the General Simplification milestone Jan 9, 2024
@sys13
Copy link

sys13 commented Mar 14, 2024

This is no longer blocked by typescript-eslint

@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg commented Mar 14, 2024 •
edited
Loading

Ha, you're right - thanks for the spot. Out of the plugins this depends on...

...so it's still blocked - just on other plugins. I'll try to get to sending issues/PRs within the week or so for any that still need it.

@sys13
Copy link

sys13 commented Mar 14, 2024

Amazing, thanks for looking into each of the packages!

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 24, 2024
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 8, 2024
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! and removed status: blocked Waiting for something else to be resolved labels Apr 8, 2024
@JoshuaKGoldberg
Copy link
Owner Author

Thanks to a PR review from @voxpelli for the last one, eslint-comments, this is ready to do!

@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg commented Apr 8, 2024 •
edited
Loading

D'oh, I'd missed from the list that eslint-plugin-deprecation still needs it. Will draft a PR now but it will be blocked on that one. Will wait till after that one is done. I'll just send this now. This can use the ESLint compat layer if needed.

@JoshuaKGoldberg JoshuaKGoldberg removed their assignment Apr 8, 2024
@JoshuaKGoldberg JoshuaKGoldberg added status: blocked Waiting for something else to be resolved and removed status: accepting prs Please, send a pull request to resolve this! labels Apr 8, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! and removed status: blocked Waiting for something else to be resolved labels Apr 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 9, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Apr 26, 2024
@JoshuaKGoldberg
feat: use ESLint Flat Config (#1457)
d2f7271 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1212
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Migrates the `.eslintrc.cjs` file to the new "flat" config format
`eslint.config.js`.

This has the added benefit of removing the last "dot" file (`.*`) that
was being linted. So that's a bit simpler of an ESLint config.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.59.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
General Simplification
Development

Successfully merging a pull request may close this issue.

feat: use ESLint Flat Config JoshuaKGoldberg/create-typescript-app
2 participants
@sys13 @JoshuaKGoldberg