Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop allowing flags on the CLI other than --config? #38

Closed
JoshuaKGoldberg opened this issue Dec 22, 2018 · 4 comments · Fixed by #287
Closed

Stop allowing flags on the CLI other than --config? #38

JoshuaKGoldberg opened this issue Dec 22, 2018 · 4 comments · Fixed by #287
Assignees
@JoshuaKGoldberg
Labels
area: cli Related to the command line (CLI) breaking change This would cause an incompatible API change status: accepting prs Please, send a pull request to resolve this! 🙏 type: enhancement New feature or request

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 22, 2018 •
edited
Loading

It's a cute feature but getting harder to sustain with rich flags. Should it be kept more simple for now?

Open to feedback! I'll leave this as is unless there's good reason not to.
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 22, 2018
@JoshuaKGoldberg JoshuaKGoldberg added type: question Further information is requested status: in discussion Not yet ready for implementation or a pull request labels Dec 22, 2018
@JoshuaKGoldberg JoshuaKGoldberg changed the title Stop allowing flags on the CLI other than --config Stop allowing flags on the CLI other than --config? Dec 22, 2018
@JoshuaKGoldberg JoshuaKGoldberg removed their assignment Dec 24, 2018
@JoshuaKGoldberg
Copy link
Owner Author

Oh, it's already like this 😄 will keep as is & improve.

@JoshuaKGoldberg
Copy link
Owner Author

Blocked on tj/commander.js#903 for providing better dialog around args.

@JoshuaKGoldberg JoshuaKGoldberg added status: blocked Waiting for something else to be resolved 🙅 area: cli Related to the command line (CLI) and removed status: in discussion Not yet ready for implementation or a pull request type: question Further information is requested labels Jan 5, 2019
@JoshuaKGoldberg
Copy link
Owner Author

I like having a clean CLI.

@JoshuaKGoldberg
Copy link
Owner Author

On (fourth? fifth?) thought, now that #283 is adding an interactive CLI tool and #285 is making -c/--config required, I think it makes sense to stop allowing runtime flags like --typeOnlyPrimitives on the CLI. Moving everything into the configuration file simplifies the option parsing quite a lot and is an easier docs read for users.

Put another way: there's no situation in which someone would be encouraged to make the CLI flags their primary form of using TypeStat. These are serious enough changes to the project that they really should be in a file.

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jul 17, 2019
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 type: enhancement New feature or request and removed status: blocked Waiting for something else to be resolved 🙅 labels Jul 17, 2019
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 17, 2019
Merged
@JoshuaKGoldberg JoshuaKGoldberg added the breaking change This would cause an incompatible API change label Jul 17, 2019
JoshuaKGoldberg pushed a commit that referenced this issue Jul 17, 2019
Removed CLI flags also included in config files
b4c2b44 
Simplifies the CLI to not allow --filter, --fixNoImplicitAny, and other settings that are now recommended to be only set in a config file. This simplifies a lot of logic around parsing raw arguments.

Fixes #38.
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: cli Related to the command line (CLI) breaking change This would cause an incompatible API change status: accepting prs Please, send a pull request to resolve this! 🙏 type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed CLI flags also included in config files JoshuaKGoldberg/TypeStat
1 participant
@JoshuaKGoldberg